[PATCH] D101689: [X32][CET] Fix alignment of .note.gnu.property section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:646
       // Emitting note header.
-      int WordSize = TT.isArch64Bit() ? 8 : 4;
+      int WordSize =
+          TT.isArch64Bit() && TT.getEnvironment() != Triple::GNUX32 ? 8 : 4;
----------------
While here, `const int`


================
Comment at: llvm/test/CodeGen/X86/note-cet-property.ll:3
 ; RUN: llc -mtriple x86_64-pc-linux < %s | FileCheck %s --check-prefix=X86_64
+; RUN: llc -mtriple x86_64-pc-linux-gnux32 < %s | FileCheck %s --check-prefix=X86
 
----------------
you can omit `<`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101689/new/

https://reviews.llvm.org/D101689