[PATCH] D101639: Add build_fence to OCaml bindings
Josh Berdine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 1 13:12:14 PDT 2021
jberdine requested changes to this revision.
jberdine added a comment.
This revision now requires changes to proceed.
Looks good apart from a typo, and a bit more documentation.
================
Comment at: llvm/bindings/ocaml/llvm/llvm.ml:1351
llvalue = "llvm_build_insertvalue"
+external build_fence : AtomicOrdering.t -> bool -> -> string -> llbuilder ->
+ llvalue = "llvm_build_fence"
----------------
================
Comment at: llvm/bindings/ocaml/llvm/llvm.mli:2600-2604
+(** [build_fence ord st name b] creates a
+ [%fence %]
+ instruction at the position specified by the instruction builder [b].
+ See the method [llvm::LLVMBuilder::CreateFence]. *)
+val build_fence : AtomicOrdering.t -> bool -> string -> llbuilder -> llvalue
----------------
It would be good to also document the [ord], [st], and [name] arguments. See e.g. the docstring for [build_atomicrmw] for how it describes the first two.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101639/new/
https://reviews.llvm.org/D101639
More information about the llvm-commits
mailing list