[PATCH] D100149: [AMDGPU][GlobalISel] Legalize and select G_SBFX and G_UBFX

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon marked 4 inline comments as done.
bcahoon added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-sbfx.mir:65
+    S_ENDPGM 0, implicit %3
+...
----------------
arsenm wrote:
> Doesn't cover the scalar cases
Scalar cases are expanded in the RegBankSelect pass.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-ubfx.mir:65
+    S_ENDPGM 0, implicit %3
+...
----------------
arsenm wrote:
> Doesn't cover the scalar cases
Scalar cases are expanded during the RegBankSelect pass.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-ubfx.mir:69
+---
+name:            test_ubfx_s8
+body: |
----------------
arsenm wrote:
> Should also test s16 which is more interesting. Also some vectors, in particular <2 x s32>, <2 x s16>, <3 x s16> and <4 x s16>
Vector cases are disallowed for G_SBFX/G_UBFX by an explicit check in the MachineVerifier.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100149/new/

https://reviews.llvm.org/D100149