[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

[Nathan James via Phabricator via llvm-commits]

njames93 added a comment.

Sorry, I thought this landed months ago. I'll take a proper look again next week.



================
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:158
+    /// name \p LocalName shoud not present.
+    void diagnoseInvalidConfigOption(StringRef LocalName) const;
+
----------------
This isn't really needed, you can just call `configurationDiag` directly.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:450
+    if (!isHungarianNotationSupportedStyle(I) && HPTOpt.hasValue())
+      Options.diagnoseInvalidConfigOption(StyleString);
+    StyleString.resize(StyleSize);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86671/new/

https://reviews.llvm.org/D86671