[PATCH] D101681: [Compiler-rt] Distinguish between testing just built runtime libraries and the libraries shipped with the compiler.

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: compiler-rt/test/lit.common.cfg.py:54
+    path = os.path.join(path, 'darwin')
+  else:
+    return None
----------------
delcypher wrote:
> @phosek I'd be curious how you think we should handle other platforms. If ` LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` wasn't a thing for Linux this would be just be something like.
> 
> ```lang=python
> if config.host_os == 'Linux':
>   path = os.path.join(path, 'linux')
> ```
> 
> but `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` makes this more complicated.
Hmm so doing something like `clang --target <target_triple> -print-runtime-dir` would actually help here. The problem is.

1. This flag is so new it doesn't exist in the compilers I'm currently trying to test.
2. It actually returns a completely incorrect path on Darwin. I've put up a patch for this https://reviews.llvm.org/D101682

I suppose I could have the current code as a fallback if `-print-runtime-dir` isn't supported, but otherwise use `-print-runtime-dir`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101681/new/

https://reviews.llvm.org/D101681