[PATCH] D101621: [STLExtras] Add a two argument form of make_early_inc_range

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 17:21:50 PDT 2021


dblaikie added a comment.

A few extra words: Generally I'd hope we move towards fewer uses of make_range (& mostly in the implementation of container-like things, rather than in random code handling iterators, like in the two places touched in this patch) and more towards having ranges around for a while to begin with.

For instance, the second piece of code, in LoopInterchange, might be nice if we had a "drop last" operation that operated on a range and this code became:

  make_early_inc_range(drop_last(*InnerLoopPreHeader))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101621/new/

https://reviews.llvm.org/D101621



More information about the llvm-commits mailing list