[PATCH] D100544: [ELF][AArch64] Write addends for TLSDESC relocations with -z rel

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/aarch64-tlsdesc-zrel.s:19
+// RUN: llvm-readobj -W -r -x .got %t-rela-addends.so | FileCheck %s --check-prefix=RELA-WITH-ADDENDS
+// RELA-WITH-ADDENDS:       Relocations [
+// RELA-WITH-ADDENDS-NEXT:   Section (5) .rela.dyn {
----------------
You can make --apply-dynamic-relocs and --no--apply-dynamic-relocs share prefixes for `Relocations`.



================
Comment at: lld/test/ELF/aarch64-tlsdesc-zrel.s:60
+
+        .hidden x                               // @x
+        .type   x, at object
----------------
Delete comment which doesn't add any value


================
Comment at: lld/test/ELF/aarch64-tlsdesc-zrel.s:61
+        .hidden x                               // @x
+        .type   x, at object
+        .section        .tbss,"awT", at nobits
----------------
Just delete .type
.size can be deleted as well.

Technically this should be @tls_object, but @object or absence is fine for assemblers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100544/new/

https://reviews.llvm.org/D100544