[PATCH] D101450: [ELF] Check the Elf_Rel addends for dynamic relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/ARM.cpp:842
+  case R_ARM_JUMP_SLOT:
+    return 0; // The stored value at this location is not the addend.
   }
----------------
The value is not used.

ld.so implementations don't use addend for JUMP_SLOT/GLOB_DAT.


================
Comment at: lld/ELF/OutputSections.cpp:571
+                toString(rel.type) + " relocation against " +
+                (rel.sym ? toString(*rel.sym) : "load address") +
+                " at offset 0x" + utohexstr(rel.getOffset()));
----------------
perhaps use

`dynamic relocation XXX at offset YYY[ against symbol ZZZ]`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101450/new/

https://reviews.llvm.org/D101450