[PATCH] D101312: [Utils] Do not remove comments in llc test script

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne updated this revision to Diff 341980.
sebastian-ne added a comment.

In D101312#2729394 <https://reviews.llvm.org/D101312#2729394>, @ggeorgakoudis wrote:

> I'm trying to understand the functionality you want to achieve. Doesn't using different prefixes avoid merging already? The test does not seem to exercise your extensions.

He, that is a good point, it was my intention to add a common prefix to the test. I added that and checked that the test now fails without the script changes.

(It will end up merging the output for the two run lines. Running FileCheck will then fail for the `GFX9-O0` case, because the comments are missing in the `CHECK-NEXT` lines.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101312/new/

https://reviews.llvm.org/D101312

Files:
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments.ll
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments.ll.expected
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/amdgpu-no-merge-comments.test
  llvm/utils/UpdateTestChecks/common.py
  llvm/utils/update_analyze_test_checks.py
  llvm/utils/update_cc_test_checks.py
  llvm/utils/update_llc_test_checks.py
  llvm/utils/update_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101312.341980.patch
Type: text/x-patch
Size: 6738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210430/34afaa3c/attachment.bin>