[PATCH] D101646: [llvm-dwarfdump] Help option output should be consistent with the command guide

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 09:52:46 PDT 2021


gbreynoo created this revision.
gbreynoo added reviewers: Higuoxing, MaskRay, dblaikie.
Herald added a reviewer: jhenderson.
Herald added a subscriber: cmtice.
gbreynoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The dwarfdump command guide shows the short options used as aliases but these are not found in the help text unless `--show-hidden` is used. Investigating other tools some follow this pattern, others like llvm-objdump show aliases with `--help`. This change fixes the help output to be consistent with the command guide.

As part of this change I updated cmdline.test, including some options that were missing testing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101646

Files:
  llvm/test/tools/llvm-dwarfdump/cmdline.test
  llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101646.341937.patch
Type: text/x-patch
Size: 8145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210430/67ce7e9e/attachment.bin>


More information about the llvm-commits mailing list