[PATCH] D101074: [X86] Canonicalize SGT/UGT compares with constants to use SGE/UGE to reduce the number of EFLAGs reads. (PR48760)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D101074#2722222 <https://reviews.llvm.org/D101074#2722222>, @lebedev.ri wrote:

> Some thoughts.
>
>> Some min/max-like patterns lose out because the comparison constant is now different from the select value - do we have any opinions on how critical this is?
>
> This does seem not ideal. Can we even check that the cmp has a select with such an operand by now?

Can we fix that in combineSelect where we canonicalize min/max patterns to use sign flag?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101074/new/

https://reviews.llvm.org/D101074