[PATCH] D101597: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro

[Nichols A. Romero via Phabricator via llvm-commits]

naromero77 added inline comments.


================
Comment at: External/SPEC/SpecCPU2017.cmake:371
 macro(speccpu2017_run_specpp)
-  cmake_parse_arguments(_arg "" "" "SPECPP_SRCS;SPECPP_DEFS" ${ARGN})
+  cmake_parse_arguments(_arg "" "SPECPP_TARGET" "SPECPP_SRCS;SPECPP_DEFS" ${ARGN})
   set(_specpp_bin ${TEST_SUITE_SPEC2017_ROOT}/bin/specpp)
----------------
Meinersbur wrote:
> [suggestion] Argument could be more self-explanatory or documented. Suggestion: `ADD_SOURCES_TO_TARGET`
> 
> (The `SPECPP_` prefixes seem unnecessary, these are function arguments that don't clash with any namespace)
Would this work?

```
cmake_parse_arguments(_arg "" "TARGET" "ADD_SRCS_TO_TARGET;DEFS" ${ARGN})
```



Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101597/new/

https://reviews.llvm.org/D101597