[PATCH] D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1

Kai Nacke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 08:54:37 PDT 2021


Kai accepted this revision.
Kai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp:1383
+      if (isParsingHLASM()) {
+        if (getLexer().is(AsmToken::Space))
+          return Error(
----------------
Nit: If you combine both `if`s, then it's more clearer that you just check that there is no space.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98276/new/

https://reviews.llvm.org/D98276



More information about the llvm-commits mailing list