[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:59
+        assert(!Record::isContinued(Slice) &&
+               "Continued bit should not be set");
+
----------------
kpn wrote:
> It looks like this allows for invalid GOFF where more data is expected but the last card of the continuation is hit.
This shouldn't be the case due to the check `if (DataLength <= 77)`. This guarantees that the remaining data will fit in the last continuation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437