[PATCH] D101201: Preserve TBAA metadata on masked intrinsics in auto-upgrade

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3900
     NewCall = Builder.CreateCall(NewFn, Args);
+    NewCall->copyMetadata(*CI);
     break;
----------------
this copies any metadata, right?

I think it makes sense to keep any metadata in this case, but it would be good to update the title & description to make this clear. And also extend the tests with a few different metadata kinds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101201/new/

https://reviews.llvm.org/D101201