[PATCH] D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopNestAnalysis.h:68
+                                               const BasicBlock *End,
+                                               bool UniquePred = false);
 
----------------
[nit] rename UniquePred -> CheckUniquePred.


================
Comment at: llvm/lib/Analysis/LoopInfo.cpp:407
+  if (&LoopNest::skipEmptyBlockUntil(ExitFromLatchSucc, GuardOtherSucc,
+                                     /*UniquePred=*/true) == GuardOtherSucc)
+    return GuardBI;
----------------
[nit] rename UniquePred -> CheckUniquePred.


================
Comment at: llvm/lib/Analysis/LoopNestAnalysis.cpp:210
+                                                const BasicBlock *End,
+                                                bool UniquePred) {
   assert(From && "Expecting valid From");
----------------
[nit] rename UniquePred -> CheckUniquePred.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94717/new/

https://reviews.llvm.org/D94717