[PATCH] D100490: [ELF] Refactor DynamicReloc to fix incorrect relocation addends

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Thanks for the update, and sorry for the delay in reviewing - bit of a busy week. I'm happy with this approach, but I think it is worth getting the go ahead from MaskRay.



================
Comment at: lld/ELF/SyntheticSections.h:453
+  DynamicReloc(RelType type, const InputSectionBase *inputSec,
+               uint64_t offsetInSec, Kind kind, Symbol &sym, int64_t addend = 0,
+               RelExpr expr = R_ABS)
----------------
The default parameters look to be used in very few places. I'm wondering if it would make sense to make 0 and R_ABS explicit at the call site as they are not obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100490/new/

https://reviews.llvm.org/D100490