[PATCH] D101294: [LoopVectorize] Fix scalarisation crash in widenPHIInstruction for scalable vectors

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 06:52:24 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4783
+      Value *UnitStepVec = nullptr, *PtrIndSplat = nullptr;
+      if (!IsUniform && VF.isScalable()) {
+        Type *VecIVTy = VectorType::get(PtrInd->getType(), VF);
----------------
Can we unify this approach for both scalable and fixed-width vectors? Or phrased differently, is there still value in the per-lane calculation for fixed-width vectors? I would expect InstCombine to simplify any extract-elements from the splat + stepvector, if those are needed individually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101294/new/

https://reviews.llvm.org/D101294



More information about the llvm-commits mailing list