[PATCH] D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-reduction-inloop.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -loop-vectorize -mtriple aarch64-unknown-linux-gnu -mattr=+sve  -S | FileCheck %s
+
----------------
Can this test be target independent by using `-force-target-supports-scalable-vectors` or does it contain any AArch64 cost-modeling?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-reduction-inloop.ll:41
+
+.lr.ph:                                           ; preds = %entry, %.lr.ph
+  %indvars.iv = phi i32 [ %indvars.iv.next, %.lr.ph ], [ 0, %entry ]
----------------
might be helpful to use a nicer name for the loop block to make the test a bit easier to parse, maybe `%loop`? Same for `._crit_edge`, perhaps `%exit`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101260/new/

https://reviews.llvm.org/D101260