[PATCH] D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision as: sfertile.
sfertile added a comment.
This revision is now accepted and ready to land.

Great work Sidharth, a couple minor nits but otherwise the patch LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:456
+  assert(PointerSize >= GV->getAlign().valueOrOne().value() &&
+         "GlobalVariables which must be alligned to be supported by the "
+         "toc data transformation.");
----------------
Minor nit: reword to "GlobalVariables with an alignment requirement stricter then 4-bytes not supported by the toc data transformation"


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:465
+
+  assert(GVType->isSized() && "A GlobalVariable's size must be know to be "
+                              "supported by the toc data transformation.");
----------------
minor nit: 'size must be know' -> 'size must be known'.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:489
+  assert(!GV->hasCommonLinkage() &&
+         "A GlobalVariable with tentative definitions cannot have the mapping "
+         "class XMC_TD.");
----------------
minor nit: pare down to just "Tentative definitions cannot have mapping class XMC_TD.".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101178/new/

https://reviews.llvm.org/D101178