[PATCH] D101076: [SVE][LoopVectorize] Add support for scalable vectorization of first-order recurrences

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 06:07:20 PDT 2021


kmclaughlin added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/first-order-recurrence.ll:1
+; RUN: opt -loop-vectorize -mtriple aarch64-unknown-linux-gnu -mattr=+sve -S < %s | FileCheck %s
+
----------------
fhahn wrote:
> Is there anything `AArch64` specific about the test? The VFs are all forced, so no cost-modeling should be needed, could this just use `-force-target-supports-scalable-vectors`?
Where possible I've moved the tests into LoopVectorize/scalable-first-order-recurrence.ll and used the `-force-target-supports-scalable-vectors` flag. There were a couple of tests (`@PR33613` & `@PR34711`) which require masked gathers, and without specifying a target architecture `setCostBasedWideningDecision` will assert as it decides to scalarise these, so I've kept these tests in AArch64/first-order-recurrence.ll.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101076/new/

https://reviews.llvm.org/D101076



More information about the llvm-commits mailing list