[PATCH] D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 01:20:15 PDT 2021


jhenderson added a comment.

There seem to be quite a few new code paths added in this patch, and I'm not convinced they are all tested? Please add the necessary testing.



================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/print-linenumber.test:1
+# RUN: llvm-objdump -d -l %p/Inputs/basic32.o | FileCheck %s --check-prefix=LINES32
+# RUN: llvm-objdump -d -l %p/Inputs/basic64.o | FileCheck %s --check-prefix=LINES64
----------------
Add a simple comment to the start of this file describing what it is testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101272/new/

https://reviews.llvm.org/D101272



More information about the llvm-commits mailing list