[llvm] f251379 - [AMDGPU] Simplify getWaitStatesSince. NFC.

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 00:58:30 PDT 2021


Author: Jay Foad
Date: 2021-04-30T08:58:24+01:00
New Revision: f251379a91d3731be079b701fda0d3551bb22b4e

URL: https://github.com/llvm/llvm-project/commit/f251379a91d3731be079b701fda0d3551bb22b4e
DIFF: https://github.com/llvm/llvm-project/commit/f251379a91d3731be079b701fda0d3551bb22b4e.diff

LOG: [AMDGPU] Simplify getWaitStatesSince. NFC.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
index b7f8246cfad2..348947c6870b 100644
--- a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -414,8 +414,7 @@ static int getWaitStatesSince(GCNHazardRecognizer::IsHazardFn IsHazard,
       return std::numeric_limits<int>::max();
   }
 
-  int MinWaitStates = WaitStates;
-  bool Found = false;
+  int MinWaitStates = std::numeric_limits<int>::max();
   for (MachineBasicBlock *Pred : MBB->predecessors()) {
     if (!Visited.insert(Pred).second)
       continue;
@@ -423,17 +422,10 @@ static int getWaitStatesSince(GCNHazardRecognizer::IsHazardFn IsHazard,
     int W = getWaitStatesSince(IsHazard, Pred, Pred->instr_rbegin(),
                                WaitStates, IsExpired, Visited);
 
-    if (W == std::numeric_limits<int>::max())
-      continue;
-
-    MinWaitStates = Found ? std::min(MinWaitStates, W) : W;
-    Found = true;
+    MinWaitStates = std::min(MinWaitStates, W);
   }
 
-  if (Found)
-    return MinWaitStates;
-
-  return std::numeric_limits<int>::max();
+  return MinWaitStates;
 }
 
 static int getWaitStatesSince(GCNHazardRecognizer::IsHazardFn IsHazard,


        


More information about the llvm-commits mailing list