[PATCH] D101227: [DOCS] Added example for G_EXTRACT and G_INSERT

Dominik Montada via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 23:44:37 PDT 2021


gargaroff added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:191
+
+  %3:_(s32) = G_EXTRACT %2, 32
+
----------------
I think you should add the type for `%2` to make it clear that this changes the type. I.e. `%2:_(s64)`


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:200
+
+  %5:_(s192) = G_INSERT %4, %3, 0
+
----------------
And same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101227/new/

https://reviews.llvm.org/D101227



More information about the llvm-commits mailing list