[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 22:33:30 PDT 2021


ChuanqiXu added a comment.

In D100739#2727808 <https://reviews.llvm.org/D100739#2727808>, @ychen wrote:

> In D100739#2718528 <https://reviews.llvm.org/D100739#2718528>, @ChuanqiXu wrote:
>
>> In D100739#2718514 <https://reviews.llvm.org/D100739#2718514>, @ychen wrote:
>>
>>> Oh, right now C++ coroutine standard is written in the way that the aligned new is not searched by the frontend. The limitation will be lifted in C++23 (hopefully).
>>
>> I see. I am curious about the relationship of compiler implementation and language standard now. For example, Clang/LLVM implement coroutine before it becomes standard. The point I curious about is that should Clang/LLVM implement based on proposals accepted only?
>
> Not a C++ language expert myself. But I think a proposal does not have to be formally accepted to kick-start the implementation (as long as the overall design is decided and the proposal is very likely to be accepted).

I see. I am still prefer to use the aligned allocator to solve the problems, although you and other reviewers prefer to use the over aligned frame.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100739/new/

https://reviews.llvm.org/D100739



More information about the llvm-commits mailing list