[PATCH] D101577: [InlineCost] Remove visitUnaryInstruction()

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 20:49:04 PDT 2021


davidxl added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1372
-  Value *Operand = I.getOperand(0);
-  if (simplifyInstruction(I, [&](SmallVectorImpl<Constant *> &COps) {
-        return ConstantFoldInstOperands(&I, COps[0], DL);
----------------
Perhaps add  a debug assert that this returns false always (for non-debug path, skip the simplification call for compile time).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101577/new/

https://reviews.llvm.org/D101577



More information about the llvm-commits mailing list