[PATCH] D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 19:11:20 PDT 2021


PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/runtime-type-info.cpp:103
       context_.Say(location_,
-          "Specification expression '%s' is neither constant nor a length type parameter"_err_en_US,
+          "Specification expression '%s' is neither constant nor a length or "
+          "kind type parameter"_err_en_US,
----------------
klausler wrote:
> KIND type parameters are necessarily constant in derived type instantiations so this message change may mislead a programmer into thinking that a specification expression in a component has to be a "bare" KIND type parameter and not a more general constant expression that can involve KIND type parameters.
Good point.  I'll revert this message to its previous value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101482/new/

https://reviews.llvm.org/D101482



More information about the llvm-commits mailing list