[PATCH] D101292: [AMDGPU] Restrict immediate scratch offsets
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 29 18:02:55 PDT 2021
arsenm added a comment.
I didn't realize the offset bugs were this convoluted. Can you add a comment/table or something to explain all the permutations somewhere?
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:178
+ "true",
+ "Negative immediate offsets in scratch instructions with an SGPR offset are not working on GFX9"
+>;
----------------
"are not working" -> "do not work"
This doesn't read like a description of the feature, and more like a comment for the feature
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:184
+ "true",
+ "Negative immediate offsets in scratch instructions with a VGPR offset need to be a multiple of 4 on GFX10"
+>;
----------------
Ditto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101292/new/
https://reviews.llvm.org/D101292
More information about the llvm-commits
mailing list