[PATCH] D97657: [lld][WebAssembly] Initial support merging string data

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Still looking over this, but had a question more up front



================
Comment at: lld/wasm/Driver.cpp:388
   config->mapFile = args.getLastArgValue(OPT_Map);
-  config->optimize = args::getInteger(args, OPT_O, 0);
+  config->optimize = args::getInteger(args, OPT_O, 1);
   config->outputFile = args.getLastArgValue(OPT_o);
----------------
this means we optimize by default now?


================
Comment at: lld/wasm/InputChunks.h:146
+
+// SectionPiece represents a piece of splittable section contents.
+// We allocate a lot of these and binary search on them. This means that they
----------------
should this say "SegmentPiece" instead of "SectionPiece"?


================
Comment at: llvm/include/llvm/MC/MCSectionWasm.h:44
+  // Bitfield of WasmSegmentFlag
+  unsigned Flags;
+
----------------
I'm a bit fuzzy now on segments and sections. Is the reason we're calling these "segment flags" here and elswhere, just because we are using segments in the wasm binary to represent them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97657/new/

https://reviews.llvm.org/D97657