[PATCH] D101534: [AMDGPU] Do not annotate features for graphics

Thu Apr 29 15:17:32 PDT 2021

arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/pal-simple-indirect-call.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: opt -S -mtriple=amdgcn-amd-amdpal -amdgpu-annotate-kernel-features  %s | FileCheck -check-prefix=GCN %s
+; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx1010 < %s | FileCheck -check-prefix=GFX9 %s
----------------
madhur13490 wrote:
> sebastian-ne wrote:
> > arsenm wrote:
> > > The IR checks look missing except for the label
> > This test is copied from `simple-indirect-call.ll` (it can’t be in the same file because amdhsa does not allow amdgpu_cs functions). The one check line still checks that there are no attributes added, but I can just remove the opt test if that is not worth it.
> Since this patch makes changes in the pass, I think `opt` check is required. `llc` line from `simple-indirect-call.ll` made sure that the test compiles fine. It's up to you if you want the similar assurance.
Can you add a comment indicating there should be no attribute on the function? This isn't the most obvious test

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101534/new/

https://reviews.llvm.org/D101534