[PATCH] D101533: [TTI] NFC: Change getTypeLegalizationCost to return InstructionCost.
Daniil Fukalov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 29 12:56:54 PDT 2021
dfukalov added a comment.
In D101533#2726575 <https://reviews.llvm.org/D101533#2726575>, @kparzysz wrote:
> In D101533#2726569 <https://reviews.llvm.org/D101533#2726569>, @sdesmalen wrote:
>
>> For this patch it's probably best to just follow precedent as to what was used before, i.e. cases that used `std::pair<unsigned, MVT>` should be changed to `std::pair<InstructionCost, MVT>`
>
> I disagree with this part. If there is a name for this type then we should use it, instead of repeating the definition. Either `TargetLoweringBase::LegalizeCost` or `TargetLowering::LegalizeCost`.
The type is actually added in the patch so if we'll leave `std::pair`, it is not needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101533/new/
https://reviews.llvm.org/D101533
More information about the llvm-commits
mailing list