[PATCH] D100305: [llvm-readobj] [ARMWinEH] Fix handling of relocations and symbol offsets

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp:254-260
+    if (!AddressOrErr) {
+      std::string Buf;
+      llvm::raw_string_ostream OS(Buf);
+      logAllUnhandledErrors(AddressOrErr.takeError(), OS);
+      OS.flush();
+      report_fatal_error(Buf);
+    }
----------------
This seems like an overly verbose way to handle errors, but it is the prevailing pattern here, so I won't object to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100305/new/

https://reviews.llvm.org/D100305