[PATCH] D101529: Fix `-Wsuggest-override` warning when building benchmark with clang-cl on Windows

Sibi Siddharthan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 11:50:35 PDT 2021


SibiSiddharthan added a comment.

In D101529#2726405 <https://reviews.llvm.org/D101529#2726405>, @kbobyrev wrote:

> For benchmark modifications, we do (see README.md) we typically patch upstream and mention the change here while patching. Is this change something that has been committed to upstream or is this the modification that you came up with yourself?

This change has not been committed upstream and I came up with it myself (similar to lines 166-168). I would prefer if that snippet would be moved outside the `if(MSVC)`  block. 
Since this is my first commit to the project I wanted to project this issue and suggest a suitable fix for it.

Thank You


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101529/new/

https://reviews.llvm.org/D101529



More information about the llvm-commits mailing list