[PATCH] D101508: [EarlyIfConversion] Avoid producing selects with identical operands

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:569
+  const MachineInstr *FDef = FReg.isVirtual() ? MRI.getVRegDef(FReg) : nullptr;
+  if (TDef && TDef == FDef)
+    return true;
----------------
Does what you mentioned in D46278 apply here too? If the MachineInstr's have multiple defs, like a LDRpre or LDP, does it need to be careful which operand it is defined in and whether they match?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101508/new/

https://reviews.llvm.org/D101508