[PATCH] D101187: [MachineCSE] Prevent CSE of non-local convergent instrs

[Daniel Sanders via Phabricator via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with the check in ProcessBlockPRE



================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:600
+    // extended definition.
+    if (MI->isConvergent() && MI->getParent() != CSMI->getParent()) {
+      LLVM_DEBUG(dbgs() << "*** Convergent MI and subexpression exist in "
----------------
foad wrote:
> Do we also need this check in ProcessBlockPRE?
I think it's needed there too


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101187/new/

https://reviews.llvm.org/D101187