[PATCH] D101474: [AMDGPU] Make some VOP3 insts commutable
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 29 09:47:32 PDT 2021
Joe_Nash added a comment.
In D101474#2725954 <https://reviews.llvm.org/D101474#2725954>, @foad wrote:
>> That is what you suggested last time on https://reviews.llvm.org/D99376
>
> OK :-)
>
> So what caused the test failures that prompted the revert of D99376 <https://reviews.llvm.org/D99376>? Did you just need to update some more lit tests?
In between when I put up the review and landed the patch, someone introduced new tests in the AMDGPU backend that differed with the commute changes. So I did a prompt rebase this time when I submitted this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101474/new/
https://reviews.llvm.org/D101474
More information about the llvm-commits
mailing list