[PATCH] D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/test/DebugInfo/Generic/machine-cp-updates-dbg-reg.mir:4
+## Ensure that when the destination register of a copy instruction is used by a
+## DBG_VALUE/DBG_VALUE_LIST, and that instruction is deleted during copy
+## propagation, the debug use is updated to the source register.
----------------



================
Comment at: llvm/test/DebugInfo/Generic/machine-cp-updates-dbg-reg.mir:12
+# CHECK: DBG_VALUE $r0, $noreg
+# CHECK-SAME: !30
+
----------------
Hardcoded metadata numbers will break in the future, this needs to be captured and compared.


================
Comment at: llvm/test/DebugInfo/Generic/machine-cp-updates-dbg-reg.mir:14
+
+# CHECK: DBG_VALUE_LIST !30
+# CHECK-SAME: $r0
----------------
IMO: better to check the entire line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101523/new/

https://reviews.llvm.org/D101523