[PATCH] D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling

[Mats Petersson via Phabricator via llvm-commits]

Leporacanthicus updated this revision to Diff 341525.
Leporacanthicus marked 4 inline comments as done.
Leporacanthicus added a comment.

Updates based on review comments:

- Fix style using PascalCase rather than camelCase.
- Add Doxygen comment for parameter.
- Change comment style for constants.
- Remove useless error output - there was no way to get to that error.
- Use llvm_unreachable instead of assert(0).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101435/new/

https://reviews.llvm.org/D101435

Files:
  llvm/include/llvm/Frontend/OpenMP/OMPConstants.h
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
  mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101435.341525.patch
Type: text/x-patch
Size: 8892 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210429/56d2df39/attachment.bin>