[PATCH] D100094: [ARM] Simplification to ARMBlockPlacement Pass.

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/block-placement.mir:22-25
-  define void @backwards_branch_sibling(i32 %N, i32 %M, i32* nocapture %a, i32* nocapture %b, i32* nocapture %c) local_unnamed_addr #0 {
-  entry:
-    unreachable
-  }
----------------
samtebbs wrote:
> malharJ wrote:
> > This test was removed because it didn't seem correct/intent was not clear.
> > The two blocks containing the t2WhileLoopStartLR have exit branches to each other.
> > 
> > Just thought it might be better to remove it as the intent is unclear.
> > Otherwise, happy to leave it in if required.
> Sorry for not looking at this sooner. The `backwards_branch_sibling` test made sure that if a backwards WLS (bb3 -> bb1) in this case was introduced by moving the loop exit (bb1) then no transformation would occur. It would still be useful to include this but adapt it to make sure that no moving happens if it would create a forwards LE.
I meant to write "backwards WLS (bb3 -> bb1 in this case) was introduced..."!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100094/new/

https://reviews.llvm.org/D100094