[PATCH] D101536: [SimplifyCFG] Common code sinking: drop profitability check in presence of conditional predecessors (PR30244)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri created this revision.
lebedev.ri added reviewers: krasin1, dvyukov, jmolloy, davidxl, spatel, MaskRay, asbirlea, nikic, fhahn, dmgreen.
lebedev.ri added a project: LLVM.
Herald added a subscriber: hiraditya.
lebedev.ri requested review of this revision.

This profitability check was added back in rL281160 <https://reviews.llvm.org/rL281160>, as a means to fix PR30244.

PR30244, in essence, talks about the fact that this extra sinking is causing
register allocation issues, for example in tsan. I've retried the two-stage
reproduction approach specified there, and i can not reproduce said issue.

A lot of time has passed since then. Perhaps this is no longer a problem?
Does anyone's benchmark still say this is still bad?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101536

Files:
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp
  llvm/test/CodeGen/AArch64/ifcvt-select.ll
  llvm/test/CodeGen/Thumb2/constant-hoisting.ll
  llvm/test/Transforms/SimplifyCFG/X86/sink-common-code.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101536.341511.patch
Type: text/x-patch
Size: 6029 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210429/7e6488c7/attachment.bin>