[PATCH] D101374: [LV] Consider Loop Unroll Hints When Making Interleave Decisions

Thu Apr 29 06:55:49 PDT 2021

bmahjour added inline comments.

================
Comment at: llvm/test/Transforms/LoopVectorize/nounroll.ll:1
+; RUN: opt < %s -passes='loop-vectorize' -debug-only=loop-vectorize -S 2>&1 | FileCheck %s
+
----------------
SjoerdMeijer wrote:
> weiwang wrote:
> > I saw this test failed in my local build and also from build bots: http://lab.llvm.org:8011/#/builders/67/builds/2504 with the following error:
> > ```
> > Input was:
> > <<<<<<
> >            1: opt: Unknown command line argument '-debug-only=loop-vectorize'. Try: '/home/buildbot/as-worker-92/clang-with-thin-lto-ubuntu/build/stage1/bin/opt --help' 
> > check:5'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
> > check:5'1      ?                                                                                                                                                          possible intended match
> >            2: opt: Did you mean '--debug-pass=loop-vectorize'? 
> > check:5'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >>>>>>
> > --
> > ```
> > 
> > I think `-debug-only` is only available when `-DLLVM_ENABLE_ASSERTIONS=ON`.
> Thanks for reporting, should be fixed with rG837fded984ed.
Ah, sorry I missed that. Thanks for the fix @SjoerdMeijer 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101374/new/

https://reviews.llvm.org/D101374