[PATCH] D101520: [AMDGPU] Remove dead early-out in GCNHazardRecognizer

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 06:21:46 PDT 2021


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.

Just to explain a bit more, I think that once we get to this check, one of the recursive calls on getWaitStatesSince must already have called IsExpired with the same WaitStates value, and that call can't have returned true otherwise getWaitStatesSince would have returned INTMAX and we'd have taken the continue on line 428. (This is assuming that the various IsExpiredFns are fairly sane in that they don't interpret their WaitStates argument differently depending on whether their MI argument is null or not.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101520/new/

https://reviews.llvm.org/D101520



More information about the llvm-commits mailing list