[PATCH] D99157: [XCore][Test] inline asm memory constraint not supported.

[Nigel Perks via llvm-commits]

Currently the only memory operands that XCore inline asm supports are indirect (*m) and they have to be globals. It doesn’t handle locals as operands, or plain “m”. (It doesn’t handle FrameIndex.) So in that sense these tests are expected to fail. As an alternative to XFAIL, I’ve started looking at handling these other cases, or at least finding out what is difficult about them. I suspect there is some difficulty, otherwise the original developer would have done it, but I can’t say what it is yet.

Thanks for the comments, they are very helpful.

(The last couple of comments didn’t appear in the patch; just to mention in case not intentional.)

Nigel


From: Eric Christopher <echristo at gmail.com>
Sent: 29 April 2021 10:59
To: Nigel Perks <reviews+D99157+public+e7951d987dfb0400 at reviews.llvm.org>
Cc: Nigel Perks <nigelp at xmos.com>; me at dylanmckay.io; Daniel Sanders <daniel_l_sanders at apple.com>; David Majnemer <david.majnemer at gmail.com>; Fedor Sergeev <fedor.sergeev at azul.com>; llvm-commits <llvm-commits at lists.llvm.org>; bhuvanendra.kumarn at amd.com; 88888yl at gmail.com; dougpuob at gmail.com; David Green <david.green at arm.com>
Subject: Re: [PATCH] D99157: [XCore][Test] inline asm memory constraint not supported.



On Wed, Apr 28, 2021 at 4:01 AM Nigel Perks via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
nigelp-xmos planned changes to this revision.
nigelp-xmos added a comment.

I'm looking at extending XCore inline asm, or at least understanding why it's a problem.

We don't typically use xfail to mean "this fails and needs to be fixed" but more "this fails and it's expected to". I do say typically though. Do you have a plan for fixing it up or something else?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210429/f175485c/attachment.html>