[PATCH] D99294: [VPlan] Representing backedge def-use feeding reduction phis.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 05:42:18 PDT 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8687
+    assert(IncR->getNumDefinedValues() == 1);
+    R->addOperand(IncR->getVPValue(0));
+  }
----------------
fhahn wrote:
> Ayal wrote:
> > while we're here: it may be useful to have a "getVPSingleValue()" which would take care of the assert (and the redundant 0)? In any case, the assert deserves an error message.
> Yes that sounds good. I'll push that as a separate commit before landing this change.
Added `getVPSingleValue` in a0e1313c2329


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99294/new/

https://reviews.llvm.org/D99294



More information about the llvm-commits mailing list