[PATCH] D100575: [flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more constructs to cover entire workshare family.

[Arnamoy B via Phabricator via llvm-commits]

arnamoy10 added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:369
   case llvm::omp::OMPD_parallel_workshare:
     CheckWorkshareBlockStmts(block, beginDir.source);
     break;
----------------
kiranchandramohan wrote:
> Nit: Can a call to HasInvalidWorksharingNesting be added here for the worksharing construct with name workshare? And add one test.
> 
Sure, done and added test case


================
Comment at: flang/lib/Semantics/check-omp-structure.h:58
     Directive::OMPD_teams_distribute_parallel_do_simd};
+static OmpDirectiveSet workShareSet{
+    Directive::OMPD_distribute_parallel_do,
----------------
kiranchandramohan wrote:
> Nit: Can you construct this set using the doSet?
Thanks, done!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100575/new/

https://reviews.llvm.org/D100575