[PATCH] D101520: [AMDGPU] Remove dead early-out in GCNHazardRecognizer

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 04:54:25 PDT 2021


critson created this revision.
critson added reviewers: foad, rampitec.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
critson requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Remove an early-out in wait state counting which can never be
taken.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101520

Files:
  llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp


Index: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -428,8 +428,6 @@
       continue;
 
     MinWaitStates = Found ? std::min(MinWaitStates, W) : W;
-    if (IsExpired(nullptr, MinWaitStates))
-      return MinWaitStates;
 
     Found = true;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101520.341472.patch
Type: text/x-patch
Size: 423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210429/c8265950/attachment.bin>


More information about the llvm-commits mailing list