[llvm] 2fa14d4 - Try to fix bots. We shouldn't be setting the entrybuilder's DL to a null one.

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 29 03:51:20 PDT 2021


Author: Amara Emerson
Date: 2021-04-29T03:51:10-07:00
New Revision: 2fa14d47005115341c14f37cb2ab00062a60fe0d

URL: https://github.com/llvm/llvm-project/commit/2fa14d47005115341c14f37cb2ab00062a60fe0d
DIFF: https://github.com/llvm/llvm-project/commit/2fa14d47005115341c14f37cb2ab00062a60fe0d.diff

LOG: Try to fix bots. We shouldn't be setting the entrybuilder's DL to a null one.

This was causing a DILocation verifier error, the old code path didn't try to do
this when building constants via the finishPendingPhis() method.

Added: 
    

Modified: 
    llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
index 818c4c5e5567..01295a03bae1 100644
--- a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
@@ -2864,8 +2864,6 @@ bool IRTranslator::translate(const Constant &C, Register Reg) {
     EntryBuilder->setDebugLoc(DILocation::get(C.getContext(), 0, 0,
                                               CurrInstDL.getScope(),
                                               CurrInstDL.getInlinedAt()));
-  else
-    EntryBuilder->setDebugLoc(DebugLoc());
 
   if (auto CI = dyn_cast<ConstantInt>(&C))
     EntryBuilder->buildConstant(Reg, *CI);


        


More information about the llvm-commits mailing list