[PATCH] D100257: [VPlan] Add VPUserID to distinguish between recipes and others.
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 29 02:07:49 PDT 2021
Ayal added a comment.
In D100257#2725020 <https://reviews.llvm.org/D100257#2725020>, @fhahn wrote:
> In D100257#2718728 <https://reviews.llvm.org/D100257#2718728>, @Ayal wrote:
>
>> Non-recipe "other" VPUsers are quite exceptional ... would it suffice to have (native) VPlan hold all 'dangling' non-recipe VPUsers of its VPBasicBlocks, as an alternative, until these are cleaned up?
>
> The blocks need to use the VPUsers to access the current value they hold I think, so I am not sure how the VPlan holding the VPUsers would look like unfortunately. It would be great if you could elaborate in a bit more detail, in case I am missing something.
The blocks will still have their VPUsers (in native; until this gets cleaned up). The thought is that whoever needs to distinguish between a block'd VPUser and a recipe'd one, would do so by consulting VPlan, rather than isa-ing the VPUser.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100257/new/
https://reviews.llvm.org/D100257
More information about the llvm-commits
mailing list