[PATCH] D101483: [llvm-objdump] add -v alias for --version

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Please update the CommandGuide docs (llvm/docs/CommandGuide) for llvm-objdump to include the new alias.



================
Comment at: llvm/test/tools/llvm-objdump/version.test:4
+
+CHECK: LLVM
+CHECK: Registered Targets:
----------------
nickdesaulniers wrote:
> rupprecht wrote:
> > MaskRay wrote:
> > > `CHECK: LLVM version`
> > > 
> > > 
> > > (While llvm-readobj/basic.test says the "LLVM" can be changed by cmake PACKAGE_NAME, I used "LLVM version" for llvm-symbolizer and it seems fine so far. )
> > "LLVM version" is fine. Just don't go further than that -- e.g. don't check "LLVM version XX.Y"
> My full version string looks like:
> ```
> LLVM (http://llvm.org/):
>   LLVM version 13.0.0git
> ...
> ```
> so this is intentionally matching the initial LLVM; I don't think matching the word `version` adds any value here.
I'd think it not unlikely for other output from the tool to incldue the `LLVM` string personally, so there's a (probably small) risk of this being a false positive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101483/new/

https://reviews.llvm.org/D101483