[PATCH] D101304: AMDGPU/llvm-readobj: Add missing tests for note parsing/displaying

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, once the clang-format issue has been addressed. Note: If you know anybody who knows AMDGPU more than me (i.e. at all), it might not hurt to get them to give the tests to give a once over before landing this, but don't worry if you don't.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5058
           << ", HSAIL Minor: " << Properties->HSAILMinorVersion
-          << ", Profile: " << Properties->Profile
-          << ", Machine Model: " << Properties->MachineModel
-          << ", Default Float Round: " << Properties->DefaultFloatRound << "]";
+          << ", Profile: "
+          << uint32_t(Properties->Profile)
----------------
jhenderson wrote:
> Nit: run clang-format.
Ping: clang-format appears to be complaining still here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101304/new/

https://reviews.llvm.org/D101304